Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: limit-conn #2450

Closed
LY-GO opened this issue Oct 17, 2020 · 6 comments · Fixed by #2465
Closed

bug: limit-conn #2450

LY-GO opened this issue Oct 17, 2020 · 6 comments · Fixed by #2465
Labels
bug Something isn't working

Comments

@LY-GO
Copy link

LY-GO commented Oct 17, 2020

Issue description

I had test the plugin of limit-conn.I found the question that the same ip only request the router by five times when conn is 5 and key is remote_addr, and i don't request the router next time.Why so that?

Environment

  • apisix version (cmd: apisix version):
  • OS:

Minimal test code / Steps to reproduce the issue

Plugin limit-conn Edit
conn=5
rejected_code=503
burst=0
key=remote_addr
default_conn_delay=0

What's the actual result? (including assertion message & call stack if applicable)

same user only visit the router with the config

What's the expected result?

i hope that the plugin only limit concurrency,and different users also continue to request the router when user request the service after first .

@membphis
Copy link
Member

i hope that the plugin only limit concurrency,and different users also continue to request the router when user request the service after first .

What is the difference between different users? The client's IP address or other things? Please confirm this first.

and please provide a mini case which we can reproduce your bug.

@LY-GO
Copy link
Author

LY-GO commented Oct 19, 2020

i hope that the plugin only limit concurrency,and different users also continue to request the router when user request the service after first .

What is the difference between different users? The client's IP address or other things? Please confirm this first.

and please provide a mini case which we can reproduce your bug.

one questions:
you had said the request would been allowed when concurrence declines.When i test the plugin of limit-conn,even through i decline the conn,the request still is unsuccess. this is a bug ?

@membphis
Copy link
Member

I think you should provide a complete case, we need to know more detailed step information.

Mainly two questions:

  1. What is the route data?
  2. What is your test method?

@LY-GO
Copy link
Author

LY-GO commented Oct 19, 2020

I think you should provide a complete case, we need to know more detailed step information.

Mainly two questions:

  1. What is the route data?
  2. What is your test method?

router-data

router-data2

plugin

2.i use the jmeter to test plugin

@membphis
Copy link
Member

let me confirm it

@juzhiyuan juzhiyuan added the checking check first if this issue occurred label Oct 19, 2020
@membphis membphis added bug Something isn't working and removed checking check first if this issue occurred labels Oct 19, 2020
@membphis
Copy link
Member

that is a bug, fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants