Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request help: we need to support multi-nodes in upstream when pass_host == node #2620

Closed
gxthrj opened this issue Nov 4, 2020 · 5 comments · Fixed by #4208
Closed

request help: we need to support multi-nodes in upstream when pass_host == node #2620

gxthrj opened this issue Nov 4, 2020 · 5 comments · Fixed by #4208
Assignees

Comments

@gxthrj
Copy link
Contributor

gxthrj commented Nov 4, 2020

Issue description

In our current version, upstream can choose not to transparently transmit the host of the original request,
but we also impose a restriction. When pass_host == node, upstream can only have one node.

We hope to get rid of this restriction. When upstream chooses not to transparently transmit the host (pass_host == node), each node transmits downwards according to its own host.

Environment

  • apisix version : 2.0
  • OS:
@gxthrj
Copy link
Contributor Author

gxthrj commented Nov 4, 2020

the latest version of openresty (OpenResty 1.19.3.1 RC1) has support this feature: add the balancer.recreate_request function, which allows user to recreate request buffer in balancer phase.
We can refer to this.

@spacewander
Copy link
Member

So we only need to enable this feature for users who use OpenResty 1.19.3?

@gxthrj
Copy link
Contributor Author

gxthrj commented Nov 4, 2020

So we only need to enable this feature for users who use OpenResty 1.19.3?

can we patch the old versions?
Or make sure that the version of OpenResty that apisix depends on is adjusted to 1.19.3 in the future?

@membphis what do you think?

@gxthrj
Copy link
Contributor Author

gxthrj commented May 7, 2021

@spacewander @membphis Is there any progress on this?

@spacewander spacewander self-assigned this May 8, 2021
spacewander added a commit to spacewander/incubator-apisix that referenced this issue May 10, 2021
Fix apache#2620
Fix apache#4197
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@membphis
Copy link
Member

So we only need to enable this feature for users who use OpenResty 1.19.3?

can we patch the old versions?
Or make sure that the version of OpenResty that apisix depends on is adjusted to 1.19.3 in the future?

@membphis what do you think?

only support 1.19.3 is fine.

In the future, APISIX will mainly work with patched openresty to support mTLS and other new functions.

spacewander added a commit to spacewander/incubator-apisix that referenced this issue May 10, 2021
Fix apache#2620
Fix apache#4197
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
gxthrj pushed a commit that referenced this issue May 13, 2021
Fix #2620
Fix #4197
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants