Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCUSS]: APISIX should check the ssl certificate in "apisix/admin/ssl" API #2816

Closed
starsz opened this issue Nov 22, 2020 · 4 comments · Fixed by #3085
Closed

[DISCUSS]: APISIX should check the ssl certificate in "apisix/admin/ssl" API #2816

starsz opened this issue Nov 22, 2020 · 4 comments · Fixed by #3085
Assignees
@spacewander
Labels
enhancement New feature or request

Comments

@starsz
Copy link
Contributor

starsz commented Nov 22, 2020

Issue description

Hi, I think APISIX should check the SSL certificate in "apisix/admin/ssl" API.
If the SSL certificate is illegal, APISIX should give some prompt.

related： #2791
@tokers
Copy link
Contributor

tokers commented Nov 22, 2020

@starsz PR's are welcome.

@tokers tokers added the enhancement New feature or request label Nov 22, 2020
@moonming
Copy link
Member

CP do this job now

@moonming
Copy link
Member

I'm not sure if dp needs this check

@spacewander
Copy link
Member

Since there are users using the admin API, I think it is needed.

@tokers tokers mentioned this issue Nov 23, 2020
Merged
4 tasks
@spacewander spacewander assigned spacewander and unassigned starsz Dec 21, 2020
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Dec 21, 2020
@spacewander
feat: validate certificate & key
2538a16 
Fix apache#296
Fix apache#2816

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander mentioned this issue Dec 21, 2020
Merged
4 tasks
spacewander added a commit that referenced this issue Dec 23, 2020
@spacewander
feat: validate certificate & key (#3085)
966d688 
Fix #296
Fix #2816

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacewander spacewander

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: validate certificate & key spacewander/incubator-apisix
4 participants
@spacewander @tokers @starsz @moonming