request help: custom index.html 4xx.html 5xx.html in Apache APISIX

[moonming]

As discussed in mailinglist: https://lists.apache.org/thread.html/rbb88d707eeaf0dbcba4d73f1f741f3621f90e84785899c47479a8557%40%3Cdev.apisix.apache.org%3E

We decided to rewrite index.html 4xx.html and 5xx.html in Apache APISIX instead of openresty.

[moonming]

we can use error_page to fix it.
like

error_page 500 502 503 504 /apisix_error_handler;

[starsz]

That sounds so cool. Please assign to me.

[juzhiyuan]

before doing this issue, could you please share your plan here? just to make sure we are on the same direction 😊

[starsz]

Directly point to apisix.apach.org is not very good.

I think we can do it as follow:

1. Provide a static HTML that contains the apisix.apache.org
2. Update the ngx_tpl to generate the apisix_error_handler like this:

error_page 500 502 503 504 @apisix_error_handler;

By the way, @juzhiyuan can you design a simple static html like this:
https://github.com/openresty/openresty/blob/master/html/50x.html

[tokers]

Directly point to apisix.apach.org is not very good.

I think we can do it as follow:

1. Provide a static HTML that contains the apisix.apache.org
2. Update the ngx_tpl to generate the apisix_error_handler like this:

error_page 500 502 503 504 @apisix_error_handler;

By the way, @juzhiyuan can you design a simple static html like this:
https://github.com/openresty/openresty/blob/master/html/50x.html

And don't forget to add test cases.

[juzhiyuan]

🤔 Why not take the first step? just to introduce our first HTML.

[starsz]

Hi, while I am working on it.
I think there is something needs to be discussed.

Reference the openresty Error page.

<p>If you are the system administrator of this resource then you should check
the <a href="http://nginx.org/r/error_log">error log</a> for details.</p>

Which link should we add?

https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L135

Can this help people to check the error log?

[juzhiyuan]

http://nginx.org/r/error_log looks good to me, waiting for others :)

[moonming]

http://nginx.org/r/error_log looks good to me, waiting for others :)

we should link to Apache APISIX for help, not nginx

[juzhiyuan]

got it