Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] Should have a unified installation path #3463

Closed
Fuchange opened this issue Feb 1, 2021 · 2 comments · Fixed by #4985
Closed

[DISCUSS] Should have a unified installation path #3463

Fuchange opened this issue Feb 1, 2021 · 2 comments · Fixed by #4985
Labels

Comments

@Fuchange
Copy link

Fuchange commented Feb 1, 2021

We have too many installation paths now.

Like the line 20 to 32 of /bin/apisix :

if [ -s './apisix/cli/apisix.lua' ]; then
    # install via source
    APISIX_LUA=./apisix/cli/apisix.lua
elif [ -s '/usr/share/lua/5.1/apisix/cli/apisix.lua' ]; then
    # install via luarock
    APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua
elif [ -s '/usr/local/apisix/deps/share/lua/5.1/apisix/cli/apisix.lua' ]; then
    # install via shell
    APISIX_LUA=/usr/local/apisix/deps/share/lua/5.1/apisix/cli/apisix.lua
else
    # install via official rpm or docker
    APISIX_LUA=/usr/local/apisix/apisix/cli/apisix.lua
fi

Skip of the first one, we have :

  • /usr/share/lua/5.1 : by luarocks make or make install (at CI)
  • /usr/local/apisix/ : by rpm or docker
  • /usr/local/apisix/deps/share/lua/5.1/ : by ./utils/install-apisix.sh install

Same problem with the deps :

  • /usr/share/lua/5.1 : by luarocks install (at CI)
  • /usr/local/apisix/deps/share/lua/5.1/ : by rpm or docker
  • ./ : by make deps (I cant even install deps to my system by make)

Should we integrate into /usr/local/apisix/ or another path ?

@spacewander spacewander changed the title feat: Should have a unified installation path [DISCUSS] Should have a unified installation path Feb 1, 2021
@Fuchange Fuchange changed the title [DISCUSS] Should have a unified installation path feat: Should have a unified installation path Feb 1, 2021
@Fuchange Fuchange changed the title feat: Should have a unified installation path [DISCUSS] Should have a unified installation path Feb 1, 2021
@spacewander
Copy link
Member

Better also start this discussion on the mail list.

@Fuchange
Copy link
Author

Fuchange commented Feb 1, 2021

Better also start this discussion on the mail list.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants