Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discuss: enrich the Available metrics of plugin prometheus #4273

Closed
fukiki opened this issue May 19, 2021 · 5 comments · Fixed by #7549
Closed

discuss: enrich the Available metrics of plugin prometheus #4273

fukiki opened this issue May 19, 2021 · 5 comments · Fixed by #7549
Assignees
@dmsolr
Labels
discuss enhancement New feature or request

Comments

@fukiki
Copy link
Contributor

fukiki commented May 19, 2021

Issue description

About the plugin prometheus, in the original metric data of APISIX, the number of the available metrics is limited.

In some practical application scenarios, request_method and remote_addr are very useful monitoring metrics.

Is there a plan to enrich the Available metrics，such as adding remote_addr, request_method in Status codes?
pe

Environment

apisix version (cmd: apisix version): 2.5
@spacewander
Copy link
Member

We can introduce a way to dynamically configure label with Nginx var?

@fukiki
Copy link
Contributor Author

fukiki commented May 19, 2021

We can introduce a way to dynamically configure label with Nginx var?

If using the way to dynamically configure label with Nginx var:

  1. This configure is only for Nginx default variables.
    The monitoring of some business response data requires further data processing, because it is not generic.
  2. Configure the specific display item of Nginx var in Attributes of Plugin Prometheus.

@spacewander
Copy link
Member

This configure is only for Nginx default variables

It is enough. Keep it simple stupid.

Attributes of Plugin Prometheus

Should be here:

apisix/conf/config-default.yaml

Line 298 in 83436ee

prometheus:
as labels are global.

@fukiki
Copy link
Contributor Author

fukiki commented May 20, 2021

@spacewander Thanks for your advice. I will try it.

@spacewander spacewander added the enhancement New feature or request label May 21, 2021
@dmsolr
Copy link
Member

dmsolr commented Feb 23, 2022

I am interested in this. May I pick it up?

@dmsolr dmsolr mentioned this issue Feb 25, 2022
Closed
4 tasks
This was referenced Jun 26, 2022
Closed
Closed
@tzssangglass tzssangglass mentioned this issue Jun 29, 2022
Closed
kingluo added a commit to kingluo/apisix that referenced this issue Jul 27, 2022
@kingluo
feat(prometheus): extra labels from nginx var for http request metrics
5c92517 
close apache#4273
@kingluo kingluo mentioned this issue Jul 27, 2022
Merged
5 tasks
spacewander pushed a commit that referenced this issue Aug 1, 2022
@kingluo @tzssangglass
feat(prometheus): extra labels from nginx var for http request metrics (
3d9e2fd 
#7549)

close #4273

Co-authored-by: tzssangglass <tzssangglass@gmail.com>
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this issue Nov 4, 2022
@kingluo @tzssangglass @Liu-Junlin
feat(prometheus): extra labels from nginx var for http request metrics (
bcfeb1b 
apache#7549)

close apache#4273

Co-authored-by: tzssangglass <tzssangglass@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmsolr dmsolr

Labels
discuss enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(prometheus): extra labels from nginx var for http request metrics kingluo/apisix
3 participants
@spacewander @dmsolr @fukiki