Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: the zipkin plugin has a logic bug in the header_filter phase #5294

Closed
zuiyangqingzhou opened this issue Oct 20, 2021 · 0 comments · Fixed by #5295
Closed

bug: the zipkin plugin has a logic bug in the header_filter phase #5294

zuiyangqingzhou opened this issue Oct 20, 2021 · 0 comments · Fixed by #5295

Comments

@zuiyangqingzhou
Copy link
Contributor

Issue description

https://github.com/apache/apisix/blob/release/2.10.0/apisix/plugins/zipkin.lua#L242-L252

There are two problems with this code:

  1. ctx.HEADER_FILTER_END_TIME variable is not reachable at line 251
  2. ctx.HEADER_FILTER_END_TIME is not necessary, it is only used in the header_filter phase

Environment

  • apisix version (cmd: apisix version):
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API):
  • apisix-dashboard version, if have:
  • the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner):
  • luarocks version, if the issue is about installation (cmd: luarocks --version):

Steps to reproduce

none

Actual result

none

Error log

none

Expected result

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant