-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zipkin): response_span doesn't have correct start time #5295
fix(zipkin): response_span doesn't have correct start time #5295
Conversation
2、complete test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a test case? You can hook the "start_child_span" to check if a valid time is given.
You can refer
Line 36 in 4dd1f67
local inject = function(mod, name) |
OK |
sorry, after trying many ways, I still don't understand how to hook the start_child_span, can you help me? @spacewander |
You can apply this patch:
|
Thank you |
Co-authored-by: jack.fu <jack.fu@yijinin.com>
fix: #5294
What this PR does / why we need it:
Pre-submission checklist: