Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sls-logger plugin support custom log format like the other logger #7129

Closed
jinghuaz opened this issue May 25, 2022 · 5 comments · Fixed by #7328
Closed

sls-logger plugin support custom log format like the other logger #7129

jinghuaz opened this issue May 25, 2022 · 5 comments · Fixed by #7328
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jinghuaz
Copy link

jinghuaz commented May 25, 2022 •
edited
Loading

Description

sls-logger plugins Can the request header field not be uploaded? for example:cookie，authorization...
@jinghuaz
Copy link
Author

image

@tokers
Copy link
Contributor

tokers commented May 26, 2022

@jinghuaz You cannot hide some headers from the sys-logger. I suggest you use the serverless plugin to remove these headers before the sys-logger runs. Note, if your backend service still needs these headers, choose a proper phase for the serverless function (e.g., header filter).

@tzssangglass tzssangglass changed the title sys-logger plugins Can the request header field not be uploaded? for example:cookie，authorization... request help: can sls-logger plugins does not upload request header? May 26, 2022
@tzssangglass
Copy link
Member

Maybe we can make sls-logger support log_format?

@tokers
Copy link
Contributor

tokers commented May 26, 2022

Maybe we can make sls-logger support log_format?

That' a good idea.

@spacewander spacewander added enhancement New feature or request good first issue Good for newcomers labels May 26, 2022
@spacewander spacewander changed the title request help: can sls-logger plugins does not upload request header? sls-logger plugin support custom log format like the other logger May 26, 2022
@jinghuaz
Copy link
Author

jinghuaz commented Jun 6, 2022

Hi,remember to notify or update the status of any updates.

spacewander added a commit to spacewander/incubator-apisix that referenced this issue Jun 26, 2022
@spacewander
feat(sls-logger): support custom log format
905f81c 
Fix apache#7129
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Jun 26, 2022
@spacewander
feat(sls-logger): support custom log format
d93b750 
Fix apache#7129
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander mentioned this issue Jun 26, 2022
Merged
5 tasks
spacewander added a commit that referenced this issue Jun 27, 2022
@spacewander
feat(sls-logger): support custom log format (#7328)
b7d1c93 
Fix #7129
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit that referenced this issue Jun 30, 2022
@spacewander
feat(sls-logger): support custom log format (#7328)
4c5380a 
Fix #7129
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this issue Nov 4, 2022
@spacewander @Liu-Junlin
feat(sls-logger): support custom log format (apache#7328)
6d92a8a 
Fix apache#7129
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sls-logger): support custom log format spacewander/incubator-apisix
4 participants
@spacewander @jinghuaz @tokers @tzssangglass