Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified apisix/core/vault.lua and apisix/secret/vault.lua #8424

Closed
soulbird opened this issue Nov 29, 2022 · 1 comment · Fixed by #8660
Closed

Unified apisix/core/vault.lua and apisix/secret/vault.lua #8424

soulbird opened this issue Nov 29, 2022 · 1 comment · Fixed by #8660
Assignees
@soulbird @shreemaan-abhishek

Comments

@soulbird
Copy link
Contributor

soulbird commented Nov 29, 2022 •
edited
Loading

Description

apisix/secret/vault.lua was introduced in #8412.

Functions currently in apisix/secret/vault.lua are copied from apisix/core/vault.lua.

The functions in apisix/core/vault.lua are only used in the jwt-auth plugin to save the jwt key, so it is not appropriate to put vault-related functions in the core module. We need to unify them.

The kms component has more comprehensive key management functions and is more versatile, so we should make the following adjustments:

  1. Use the vault function provided by the kms component to replace the vault-related functions in the jwt-auth plugin. This will introduce a break change due to changes in configuration.
  2. Delete the apisix/core/vault.lua file.
@soulbird soulbird self-assigned this Nov 29, 2022
@soulbird soulbird changed the title Unified apisix/core/vault.lua and apisix/kms/vault.lua Unified apisix/core/vault.lua and apisix/secret/vault.lua Jan 6, 2023
@shreemaan-abhishek
Copy link
Contributor

shreemaan-abhishek commented Jan 11, 2023 •
edited
Loading

To be noted: apisix/admin/kms.lua has been renamed to apisix/admin/secrets.lua. Ref: PR #8448

@shreemaan-abhishek shreemaan-abhishek mentioned this issue Jan 12, 2023
Merged
5 tasks
spacewander pushed a commit that referenced this issue Jan 30, 2023
@shreemaan-abhishek
change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault…
c8d5afb 
….lua (#8660)

Fixes #8424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulbird soulbird

@shreemaan-abhishek shreemaan-abhishek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua shreemaan-abhishek/apisix
2 participants
@soulbird @shreemaan-abhishek