Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add "-v" flag for verbosity in apisix start #10107

Merged
merged 3 commits into from
Sep 7, 2023
Merged

feat: add "-v" flag for verbosity in apisix start #10107

merged 3 commits into from
Sep 7, 2023

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Aug 29, 2023 •
edited
Loading

Description

Follow up on this suggestion to add consistency in flag usage.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Revolyssup
feat: add "-v" flag for verbosity in apisix start
409c079 
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
@Revolyssup Revolyssup added the doc Documentation things label Aug 29, 2023
kayx23
kayx23 reviewed Aug 29, 2023
View reviewed changes
docs/zh/latest/FAQ.md Outdated Show resolved Hide resolved
@Revolyssup @kayx23
Update docs/zh/latest/FAQ.md
54d0df0 
Co-authored-by: Traky Deng <trakydeng@gmail.com>
@Revolyssup Revolyssup self-assigned this Aug 29, 2023
pottekkat
pottekkat approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Rerunning CI.

@monkeyDluffy6017
Copy link
Contributor

@Revolyssup please make the ci pass

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Sep 5, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 0847429 into apache:master Sep 7, 2023
40 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sn0rt Sn0rt Sn0rt approved these changes

@jiangfucheng jiangfucheng jiangfucheng approved these changes

@kayx23 kayx23 kayx23 approved these changes

@pottekkat pottekkat pottekkat approved these changes

@AlinsRan AlinsRan Awaiting requested review from AlinsRan

Assignees

@Revolyssup Revolyssup

Labels
doc Documentation things wait for update wait for the author's response in this issue/PR
Projects
Apache APISIX backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Revolyssup @monkeyDluffy6017 @Sn0rt @jiangfucheng @kayx23 @pottekkat