Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Rust related scripts and doc update #10121

Merged

Conversation

Revolyssup
Copy link
Contributor

Description

This is a follow up PR to #9936 and removes mentions of RUST from docs as well as remove the scripts that install and check for rust.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this as well:

&& curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sudo sh -s -- -y \
&& source "$HOME/.cargo/env" \
&& export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse \
# next line is for rust cdylib compile on musl
&& export RUSTFLAGS="-C target-feature=-crt-static" \

Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
@Revolyssup
Copy link
Contributor Author

@shreemaan-abhishek done

@monkeyDluffy6017 monkeyDluffy6017 merged commit 39a5d79 into apache:master Sep 4, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants