Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add info about building image from source #10172

Merged
merged 3 commits into from
Sep 12, 2023
Merged

docs: add info about building image from source #10172

merged 3 commits into from
Sep 12, 2023

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

Ref: #9586 (comment)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

kayx23
kayx23 previously approved these changes Sep 8, 2023
View reviewed changes
pottekkat
pottekkat reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bullets not needed here IMO. Suggested to make it less wordy as well.

docs/en/latest/building-apisix.md Outdated Show resolved Hide resolved
docs/en/latest/building-apisix.md Outdated Show resolved Hide resolved
@shreemaan-abhishek @pottekkat
Update docs/en/latest/building-apisix.md
42860c3 
Co-authored-by: Navendu Pottekkat <navendupottekkat@gmail.com>
@shreemaan-abhishek @pottekkat
Update docs/en/latest/building-apisix.md
b41d740 
Co-authored-by: Navendu Pottekkat <navendupottekkat@gmail.com>
@monkeyDluffy6017 monkeyDluffy6017 merged commit f47c2d7 into apache:master Sep 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@pottekkat pottekkat pottekkat approved these changes

@kayx23 kayx23 kayx23 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreemaan-abhishek @monkeyDluffy6017 @kayx23 @pottekkat