Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jwe decrypt plugin #10252

Merged
merged 23 commits into from
Dec 4, 2023
Merged

Conversation

fishioon
Copy link
Contributor

@fishioon fishioon commented Sep 25, 2023

Description

Like kong jwe-decrypt plugin.
Sometimes we need pass encrypt message with request header, like jwe

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@fishioon fishioon changed the title [WIP]feat: add jwe decrypt plugin WIP: feat: add jwe decrypt plugin Sep 25, 2023
@monkeyDluffy6017 monkeyDluffy6017 marked this pull request as draft September 25, 2023 03:42
@monkeyDluffy6017
Copy link
Contributor

@fishioon click here when you are ready
image

@fishioon fishioon marked this pull request as ready for review September 25, 2023 03:44
@monkeyDluffy6017
Copy link
Contributor

please make the ci pass

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Sep 25, 2023
@membphis
Copy link
Member

missing test cases and ci failed, pls fix them first

@fishioon fishioon changed the title WIP: feat: add jwe decrypt plugin feat: add jwe decrypt plugin Oct 3, 2023
@fishioon fishioon force-pushed the feat-jwe branch 2 times, most recently from 92ea674 to fa89f03 Compare October 3, 2023 17:14
@monkeyDluffy6017
Copy link
Contributor

Good job! please make the ci pass, thanks!

@fishioon fishioon force-pushed the feat-jwe branch 7 times, most recently from 49a424c to e659cff Compare October 9, 2023 05:38
@monkeyDluffy6017
Copy link
Contributor

@fishioon please make the ci pass

@fishioon fishioon force-pushed the feat-jwe branch 2 times, most recently from 2e61384 to b51f672 Compare October 12, 2023 12:47
@fishioon
Copy link
Contributor Author

@fishioon please make the ci pass

done

Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me. I haven't yet reviewed the doc tho.

apisix/plugins/jwe-decrypt.lua Show resolved Hide resolved
apisix/plugins/jwe-decrypt.lua Outdated Show resolved Hide resolved
@monkeyDluffy6017
Copy link
Contributor

Thanks for you contribution! We will check this pr later

}
}
--- response_body
passed
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real request test?

=== TEST 18: verify (in header)
--- request
GET /hello
--- more_headers
Authorization: Bearer eyJhbGciOiJkaXIiLCJraWQiOiJ1c2VyLWtleSIsImVuYyI6IkEyNTZHQ00ifQ..MTIzNDU2Nzg5MDEy.6JeRgm02rpOJdg.4nkSYJgwMKYgTeacatgmRw
--- response_body
hello world

@monkeyDluffy6017
Copy link
Contributor

@fishioon please resolve the review comments

@fishioon
Copy link
Contributor Author

@fishioon please resolve the review comments

@shreemaan-abhishek Help me!

@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR user responded labels Dec 1, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 225e18f into apache:master Dec 4, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants