-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add token support for consul discovery (#9532) #10278
feat: add token support for consul discovery (#9532) #10278
Conversation
Good job! I will check it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please support consul_kv
as well.
Good job! please resolve the review comments, thanks! |
@shreemaan-abhishek I'am working on that. Can anyone please tell me how to write an assert for accepting one of two error codes?
but this doesn't seem to work. It doesn't match but according to Regex101 it should.
The reason is, that bootstrapping the ACL twice is not allowed which returns 403 which is totally fine. |
Could you please share the complete test case?
Do the test case results alternate between 200 and 403? If it returns 403 every time you can just check for the 403 error code 🤔 |
This is the complete test:
Yes the result alternates. It returns 200 the first time but every re-run will return 403 because the ACL system can only be bootstrapped once. And because testing the ACL bootstrap procedure of consul is not the case here, I would say both retrurn codes are fine. |
Is it okay to not consider the If you are testing manually in your machine consider restarting the docker container or something. I hope I didn't get you wrong 😂 |
The thing is that i'am sharing the consul docker instance between the test files consul.t and consul_kv.t. EDIT: Got it working. There is a special |
please fix the failing tests |
f6fcfb8
@monkeyDluffy6017 can you please re-run the failed chaos-test workflow? It couldnt install helm for some reason. |
Description
This PR adds support for ACL tokens when using consul or consul_kv service discovery as described in #9532.
Checklist