feat: support config stream_route upstream in service #10298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
|
Please make the ci pass |
monkeyDluffy6017
added
the
wait for update
it can't pass in master |
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
|
Please make the ci pass |
monkeyDluffy6017
changed the title
|
Please update the related doc: https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md |
| @@ -1021,6 +1021,7 @@ function _M.stream_init_worker() | |||
| plugin.init_worker() | |||
| xrpc.init_worker() | |||
| router.stream_init_worker() | |||
| require("apisix.http.service").init_worker() | |||
There was a problem hiding this comment.
Can the service.lua be moved out of the http directory?
There was a problem hiding this comment.
no, obviously service is designed for http
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
monkeyDluffy6017
approved these changes
Oct 13, 2023
shreemaan-abhishek
approved these changes
Oct 14, 2023
hongbinhsu
pushed a commit
to fitphp/apix
that referenced
this pull request
Nov 1, 2023
* upstream/master: (83 commits) fix: make install failed on mac (apache#10403) feat(zipkin): add variable (apache#10361) test(clickhouse-logger): to show that different endpoints will be chosen randomly (apache#8777) chore(deps): bump actions/setup-node from 3.8.1 to 4.0.0 (apache#10381) ci: fix the grpc test error (apache#10388) ci: trigger ci when doc-lint.yml changes (apache#10382) docs: fix usage of incorrect default admin api port (apache#10391) feat: Add authorization params to openid-connect plugin (apache#10058) feat: integrate authz-keycloak with secrets resource (apache#10353) fix(traffic-split): post_arg match fails because content-type contains charset (apache#10372) fix(consul): worker will not exit while reload or quit (apache#10342) chore: update rules for unresponded issues (apache#10354) docs: Update APISIX usecases in README (apache#10358) test: use http2 to test limit-req plugin (apache#10334) test: use http2 to test limit-conn plugin (apache#10332) chore: remove stream_proxy.only in config-default.yaml (apache#10337) docs: update underscore to hyphen in HTTP headers in `response-rewrite` plugin (apache#10347) fix: typos in comments (apache#10330) feat: support config stream_route upstream in service (apache#10298) fix: keep healthcheck target state when upstream changes (apache#10312) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
service_idfor stream_route, allows config upstream in service.Checklist