Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove 0 from required_acks allowed values for kafka-logger #10469

Merged
merged 2 commits into from
Nov 11, 2023
Merged

fix: remove 0 from required_acks allowed values for kafka-logger #10469

merged 2 commits into from
Nov 11, 2023

Conversation

kayx23
Copy link
Member

@kayx23 kayx23 commented Nov 9, 2023 •
edited
Loading

Description

While the doc was updated in #10126, the code was not. As a user, it could be confusing to see the doc mentions required_acks doesn't support 0, yet the schema and test say otherwise.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@kayx23 kayx23 merged commit e1503dc into apache:master Nov 11, 2023
32 checks passed
@kayx23 kayx23 deleted the kafka-ack branch November 11, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@Revolyssup Revolyssup Awaiting requested review from Revolyssup

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayx23 @monkeyDluffy6017 @shreemaan-abhishek