fix: do not invoke add_header if value resolved as nil #10619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If header_value is resolved to nil or empty table,
add_header
will throw an error https://github.com/openresty/lua-resty-core/blob/master/lib/resty/core/request.lua#L364It's better to do nothing.
ref: https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/req.md#add_header
Checklist