Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http-dubbo plugin #10703

Merged
merged 40 commits into from
Feb 1, 2024
Merged

feat: add http-dubbo plugin #10703

merged 40 commits into from
Feb 1, 2024

Conversation

ShenFeng312
Copy link
Contributor

@ShenFeng312 ShenFeng312 commented Dec 25, 2023

Description

添加http-dubbo 插件 提供http 协议转dubbo 协议。并使用json作为默认的序列化方式。备注:2.xdubbo可能需要对dubbo 源码进行一定量改造。因为2.xdubbo 如果不全局使用fastjson作为序列化方式时,在对返回结果进行序列化时没有按照协议规定选择序列化方式。这是dubbo2.x的bug。

Add the http-dubbo plugin to facilitate the conversion from HTTP protocol to Dubbo protocol, utilizing JSON as the default serialization format. Note: For Dubbo 2.x, it may be necessary to make certain modifications to the Dubbo source code. This is because, in Dubbo 2.x, if fastjson is not used globally as the serialization method, there is a bug where the serialization format for returning results is not selected according to the protocol specifications during the serialization process.
-------Translated by ChatGPT.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@ShenFeng312 ShenFeng312 changed the title add http-dubbo plugin feat:add http-dubbo plugin Dec 25, 2023
@ShenFeng312 ShenFeng312 changed the title feat:add http-dubbo plugin feat: add http-dubbo plugin Dec 25, 2023
@smileby
Copy link
Contributor

smileby commented Dec 25, 2023

Could you add test cases?

@ShenFeng312
Copy link
Contributor Author

ShenFeng312 commented Dec 25, 2023

Could you add test cases?

Yes, I am learning how to write test cases. I will add them later.

@Vacant2333
Copy link
Contributor

we may need docs for the plugin

apisix/plugins/http-dubbo.lua Outdated Show resolved Hide resolved
apisix/plugins/http-dubbo.lua Outdated Show resolved Hide resolved
apisix/plugins/http-dubbo.lua Show resolved Hide resolved
apisix/plugins/http-dubbo.lua Show resolved Hide resolved
apisix/plugins/http-dubbo.lua Outdated Show resolved Hide resolved
apisix/plugins/http-dubbo.lua Outdated Show resolved Hide resolved
@ShenFeng312
Copy link
Contributor Author

ShenFeng312 commented Dec 27, 2023

@smileby @soulbird Sorry, I'm busy now. I will fix them and add test cases next week.

@ShenFeng312
Copy link
Contributor Author

I will add more test cases after these two have been completed

@smileby @soulbird

@monkeyDluffy6017
Copy link
Contributor

please merge the master

@ShenFeng312
Copy link
Contributor Author

please make the ci pass

Hi. Ci passed. I think we can merge this PR now @monkeyDluffy6017

@Vacant2333
Copy link
Contributor

please make the ci pass

Hi. Ci passed. I think we can merge this PR now @monkeyDluffy6017

this pr needs review first, its a big one, may takes some days, @shreemaan-abhishek @zll600 @sheharyaar can u help take a look~

@monkeyDluffy6017
Copy link
Contributor

@ShenFeng312 there is still a ci error

@shreemaan-abhishek
Copy link
Contributor

please add docs as well.

@ShenFeng312
Copy link
Contributor Author

please add docs as well.

OK I will

@Vacant2333
Copy link
Contributor

please add docs as well.

can we add the docs after the pr merge? its a big one i think we can split it

@sheharyaar
Copy link
Contributor

@ShenFeng312 , is this PR related to dubbo-proxy ?? And is it related to this issue :
#10848 ??

@ShenFeng312
Copy link
Contributor Author

@ShenFeng312 , is this PR related to dubbo-proxy ?? And is it related to this issue : #10848 ??

The PR is not related to dubbo-proxy. However, it addresses the requirements mentioned in issue #10848 and should help resolve that issue.

@monkeyDluffy6017
Copy link
Contributor

Please make the ci pass

@ShenFeng312
Copy link
Contributor Author

@monkeyDluffy6017 it was OK

@monkeyDluffy6017 monkeyDluffy6017 merged commit ca81d16 into apache:master Feb 1, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user responded wait for update wait for the author's response in this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants