Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(response-rewrite): support brotli when use filters.regex option #10733

Merged
merged 4 commits into from
Jan 4, 2024
Merged

feat(response-rewrite): support brotli when use filters.regex option #10733

merged 4 commits into from
Jan 4, 2024

Conversation

yuweizzz
Copy link
Contributor

Description

Related: #10637 and #10562

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@yuweizzz yuweizzz changed the title feature(response-rewrite): support brotli when use filters.regex option feat(response-rewrite): support brotli when use filters.regex option Dec 29, 2023
shreemaan-abhishek
shreemaan-abhishek reviewed Jan 1, 2024
View reviewed changes
apisix/plugins/response-rewrite.lua Show resolved Hide resolved
apisix/plugins/response-rewrite.lua Outdated Show resolved Hide resolved
t/plugin/response-rewrite3.t Show resolved Hide resolved
@monkeyDluffy6017
Copy link
Contributor

please make the ci pass

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Jan 2, 2024
@yuweizzz
Copy link
Contributor Author

yuweizzz commented Jan 3, 2024

I've reviewed the ci logs and the failure was due to a network error, could you please rerun the ci?

@monkeyDluffy6017 monkeyDluffy6017 merged commit ab67b09 into apache:master Jan 4, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

Assignees
No one assigned
Labels
user responded wait for update wait for the author's response in this issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuweizzz @monkeyDluffy6017 @shreemaan-abhishek