feat: support more sensitive fields for encryption #11095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsz
reviewed
Mar 27, 2024
starsz
reviewed
Mar 28, 2024
| end | ||
|
|
||
| local encrypted = core.table.try_read_attr(local_conf, "apisix", "data_encryption", | ||
| "enable_encrypt_fields") and (core.config.type == "etcd") |
There was a problem hiding this comment.
Why do we need to add this ?
I think the check_schema is run before the fields encrypted.
There was a problem hiding this comment.
if data encryption is enabled then the secret length will be more than 32. So we should not check the length if data encryption is on.
I think the check_schema is run before the fields encrypted.
yes. This is why we cannot use the code in plugin.lua, so I just copied the logic 😅
There was a problem hiding this comment.
if data encryption is enabled then the secret length will be more than 32.
Why the secret length will be more than 32. Is the secret is encrypted?
There was a problem hiding this comment.
yes, exactly.
moonming
approved these changes
Mar 28, 2024
starsz
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some sensitive plugin fields aren't under the protection of
encrypt_fieldsfeature. It has been addressed in this PR.Checklist