fix(datadog): report consumer username tag #11354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzp2010
requested review from
juzhiyuan,
gxthrj,
nic-6443,
moonming,
nic-chen,
bisakhmondal,
Revolyssup,
SkyeYoung,
pottekkat,
shreemaan-abhishek and
AlinsRan
SkyeYoung
approved these changes
Jun 16, 2024
bisakhmondal
approved these changes
Jun 16, 2024
moonming
approved these changes
Jun 16, 2024
nic-chen
approved these changes
Jun 16, 2024
Closed
5 tasks
ssignik
added a commit
to ssignik/apisix
that referenced
this pull request
Jun 21, 2024
fix(datadog): report consumer username tag (apache#11354)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When datadog tries to upload metrics containing the consumer username tag, it fails.
Basically the code there tries to splice a string with a table (without __tostring), which is completely wrong, and it has had this problem since the original version of the plugin, which went undetected because the original authors didn't write test cases related.
The previous author of PR #10934 was closed by bot for not adding test cases and no longer responding. Thanks to the issue reporter and the author of the previous PR.
Fixes #9269
Checklist