fix: allow trailing period in SNI and CN for SSL #11414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonming
reviewed
Jul 18, 2024
apisix/ssl.lua
Outdated
| @@ -212,6 +214,7 @@ end | |||
|
|
|||
|
|
|||
| function _M.fetch_cert(sni, cert) | |||
| core.log.warn(debug.traceback()) | |||
There was a problem hiding this comment.
can we remove this debug log? others LGTM
This reverts commit 4473a44.
moonming
approved these changes
Jul 18, 2024
Revolyssup
approved these changes
Jul 18, 2024
nic-chen
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
APISIX would disallow requests under TLS if there was a mismatch based difference of presence/absence of a trailing period between SNI and CN. This has been fixed.
Check test cases for more info.
Checklist