Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove core.grpc module #11427

Merged
merged 1 commit into from
Jul 24, 2024
Merged

chore: remove core.grpc module #11427

merged 1 commit into from
Jul 24, 2024

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

https://lists.apache.org/thread/05xvcbvty1txr1owx61vyktsmgs2pdd5

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

membphis
membphis approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^_^

@Revolyssup Revolyssup self-requested a review July 24, 2024 04:59
@moonming moonming merged commit 507df12 into apache:master Jul 24, 2024
31 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the remove-grpc branch July 24, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@moonming moonming moonming approved these changes

@Revolyssup Revolyssup Revolyssup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreemaan-abhishek @membphis @moonming @Revolyssup