Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jwt-auth, token exp cannot be set normally #11650 #11653

Closed
wants to merge 1 commit into from

Conversation

fanyu-byte
Copy link

@fanyu-byte fanyu-byte commented Oct 15, 2024

Description

Swapped the two parameters of core.table.merge in the get_real_payload method, which caused us to be unable to set the expiration time of the token

Fixes #11650

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working plugin labels Oct 15, 2024
@fanyu-byte
Copy link
Author

when we generate a token, exp on payload not effective
image
image

after this change it works:
image
image

Please cherry pick this change to another branch

@moonming
Copy link
Member

closed, reason is here #11650 (comment)

@moonming moonming closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants