Making username and password as required fields for basic auth plugin #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
requested changes
Mar 13, 2020
| @@ -123,7 +123,10 @@ passed | |||
| ngx.HTTP_PUT, | |||
| [[{ | |||
| "plugins": { | |||
| "basic-auth": {} | |||
| "basic-auth": { | |||
| "username": "foo", | |||
There was a problem hiding this comment.
That is wrong.
When a user requests, the authentication information is placed in an HTTP header.
There was a problem hiding this comment.
Hi @membphis , I'm a bit unclear, this test case is enabling basic auth plugin using admin api.
The test case 8 does the verification by adding the http header.
=== TEST 8: verify
--- request
GET /hello
--- more_headers
Authorization: Basic Zm9vOmJhcg==
--- response_body
hello world
--- no_error_log
[error]
I agree, in order to enable basic auth the admin does not have to send the same info again. Any suggestion how to tackle this would be helpful. I guess the scenario is the same with key-auth plugin as well.
|
@sshniro I replied right now: #1244 (comment) I think we can close this PR. |
|
Thanks, that makes it clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1244