[WIP] bugfix: check plugin schema when sync data #1875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Jul 27, 2020
| -- check plugins schema | ||
| local plugins_conf = item.plugins | ||
| if plugins_conf then | ||
| for name, plugin_conf in pairs(plugins_conf) do |
There was a problem hiding this comment.
check the plugin conf in this way, it is not a good way.
config_etcd.lua is a basic component, it should not know the plugin.
I think we can export a new option when creating new config_etcd object, then we can add more check logic in filter_func .
Example:
core.config.new("/routes", {
automatic = true,
item_schema = core.schema.route,
filter_func = function ()
-- your code
end
filter = filter,
})
|
@wrl96 please rebase your branch and fix the failed test cases. |
|
@wrl96 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix #1604
Pre-submission checklist: