Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(k8s): removed unnecessary configurations. #1891

Merged
merged 4 commits into from
Jul 31, 2020

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Jul 23, 2020

What this PR does / why we need it:

1.make config.yaml from the latest version
2.remove some config not necessary

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@moonming moonming changed the title style:modify kubernetes doc,make config.yaml from the latest version … doc(k8s): removed unnecessary configurations. Jul 23, 2020
kubernetes/README.md Outdated Show resolved Hide resolved
kubernetes/README.md Outdated Show resolved Hide resolved
kubernetes/README.md Show resolved Hide resolved
kubernetes/README.md Outdated Show resolved Hide resolved
kubernetes/config.sh Outdated Show resolved Hide resolved
@membphis
Copy link
Member

@gxthrj please take a look at the output of Github Action:

https://github.com/apache/incubator-apisix/pull/1891/checks?check_run_id=913422137#step:6:61

Scan detected 2 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 2 error(s) in 2 file(s):
  [./kubernetes/config.sh]:
       1: file does not include required license header.
  [./kubernetes/deployment.yaml]:
     113: file does not end with EOL.

@gxthrj
Copy link
Contributor Author

gxthrj commented Jul 29, 2020

@gxthrj please take a look at the output of Github Action:

https://github.com/apache/incubator-apisix/pull/1891/checks?check_run_id=913422137#step:6:61

Scan detected 2 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 2 error(s) in 2 file(s):
  [./kubernetes/config.sh]:
       1: file does not include required license header.
  [./kubernetes/deployment.yaml]:
     113: file does not end with EOL.

done

@moonming moonming merged commit f37a1dd into apache:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants