Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: health check supports custom host port. #1914

Merged
merged 3 commits into from
Jul 28, 2020
Merged

feature: health check supports custom host port. #1914

merged 3 commits into from
Jul 28, 2020

Conversation

shuaijinchao
Copy link
Member

What this PR does / why we need it:

FIX #1811

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@membphis
Copy link
Member

add test cases about invalid port, eg: port = -1 or port = 9999999

membphis
membphis reviewed Jul 28, 2020
View reviewed changes
apisix/schema_def.lua Outdated Show resolved Hide resolved
@shuaijinchao
Copy link
Member Author

add test cases about invalid port, eg: port = -1 or port = 9999999

OK, no problem

@shuaijinchao
Copy link
Member Author

@membphis already fixed, please recheck.

@membphis membphis merged commit 520ef31 into apache:master Jul 28, 2020
@membphis
Copy link
Member

@shuaijinchao merged, many thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request help: Health Checks can support customized PORT ?
2 participants
@shuaijinchao @membphis