Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option for cors #1963

Merged
merged 7 commits into from
Aug 1, 2020
Merged

feat: add option for cors #1963

merged 7 commits into from
Aug 1, 2020

Conversation

ShiningRush
Copy link
Contributor

fixed with #1915 #1704

membphis
membphis reviewed Jul 31, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor style

apisix/plugins/cors.lua Outdated Show resolved Hide resolved
apisix/plugins/cors.lua Outdated Show resolved Hide resolved
membphis
membphis reviewed Jul 31, 2020
View reviewed changes
t/plugin/cors.t Outdated Show resolved Hide resolved
@membphis membphis merged commit 2936c7d into apache:master Aug 1, 2020
@ShiningRush ShiningRush deleted the feat/add-option-cors branch August 25, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiningRush @membphis