fix: proxy_set_header Host $host may lose port info

[halfcrazy]

What this PR does / why we need it:

proxy_set_header Host $host may lose port info, use http_host instead.

Pre-submission checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases?
• Have you modified the corresponding document?
• Is this PR backward compatible?

[membphis]

pls add test cases

[moonming]

@halfcrazy $http_host ONLY get value from request header field, is that ok?
$host: in this order of precedence: host name from the request line, or host name from the “Host” request header field, or the server name matching a request
refer to: http://nginx.org/en/docs/http/ngx_http_core_module.html

[moonming]

proxy_set_header Host $host may lose port info, use http_host instead.

And is this PR anything with proxy_set_header?

[halfcrazy]

proxy_set_header Host $host may lose port info, use http_host instead.

And is this PR anything with proxy_set_header?

Since we use proxy_set_header to set the Host field in header for upstream server. Nginx $host variable doesn't contain a port, as rfc2616 a request to ports besides 80, 443 should always include a port in the host field.

[1]https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.23

[halfcrazy]

pls add test cases

Sorry, I have no idea how to add a test for this case.

[moonming]

pls add test cases

Sorry, I have no idea how to add a test for this case.

you can add test cases to test if port exists.

[membphis]

@halfcrazy https://github.com/apache/apisix/blob/master/.travis/apisix_cli_test.sh

you can take a look at this shell script for testing.

[halfcrazy]

Test case added.

[membphis]

Test case added.

"proxy_set_header Host $host may lose port info, use http_host instead."

we need to add test for this case

[moonming]

ping @halfcrazy @membphis

[dbit-xia]

Hi, May I ask the conclusion of this question? tks @halfcrazy

[halfcrazy]

Hi, May I ask the conclusion of this question? tks @halfcrazy

There's a lot of change to apisix template since this pr, the $host indeed should change to $http_host but I don't familiar with Perl style test cant write a test for this.

[membphis]

let us reopen this PR, I think @Firstsawyou can help you, all right? @Firstsawyou

[membphis]

I think we need to process the conflict files first.

[Firstsawyou]

let us reopen this PR, I think @Firstsawyou can help you, all right? @Firstsawyou

Let me see.

[Firstsawyou]

hi @halfcrazy
The title of the PR should look like this:
fix: proxy_set_header Host $host may lose port info

[lilien1010]

LGTM