Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add referer-restriction plugin #2352

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Oct 4, 2020

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

local schema = {
type = "object",
properties = {
optional = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need a more meaningful name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s still a bit confused, maybe we could use ʻallow_no_referer` or something. just a suggestion

t/plugin/referer-restriction.t Show resolved Hide resolved
@spacewander
Copy link
Member Author

@membphis
Done

@membphis membphis merged commit 5b97223 into apache:master Oct 6, 2020
@membphis
Copy link
Member

membphis commented Oct 6, 2020

@spacewander merged, many thx

@moonming moonming added this to the 2.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants