Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support multiple ports like stream listen in http and https … #2409

Merged
merged 7 commits into from
Oct 17, 2020

Conversation

tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented Oct 13, 2020

…listen port. (#1195)

fix #1195

What this PR does / why we need it:

The Apache APISIX listens to a single port by default in http and https, this PR support multiple ports listen.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@membphis
Copy link
Member

CI output:

+ ./bin/apisix init
lua: ./bin/apisix:887: attempt to call field 'new' (a nil value)
stack traceback:
	./bin/apisix:887: in function '?'
	./bin/apisix:1154: in main chunk
	[C]: ?
Error: Process completed with exit code 1.

@tzssangglass
Copy link
Member Author

someone else can approved?

1 similar comment
@tzssangglass
Copy link
Member Author

someone else can approved?

FAQ.md Outdated Show resolved Hide resolved
FAQ_CN.md Outdated Show resolved Hide resolved
FAQ_CN.md Outdated Show resolved Hide resolved
FAQ_CN.md Outdated Show resolved Hide resolved
@nic-chen
Copy link
Member

need test case for change.

here is an example:

https://github.com/apache/apisix/blob/master/.travis/apisix_cli_test.sh#L156-L170

FAQ.md Outdated Show resolved Hide resolved
@membphis
Copy link
Member

please take a look at the output of CI: https://github.com/apache/apisix/pull/2409/checks?check_run_id=1260519517#step:6:125

Scan detected 6 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 6 error(s) in 2 file(s):
  [./FAQ.md]:
     279: line has trailing whitespace.
     287: line has trailing whitespace.
     289: line has trailing whitespace.
     298: line has trailing whitespace.
  [./FAQ_CN.md]:
     237: line has trailing whitespace.
     239: line has trailing whitespace.

@tzssangglass
Copy link
Member Author

need test case for change.

here is an example:

https://github.com/apache/apisix/blob/master/.travis/apisix_cli_test.sh#L156-L170

ok, thx

@tzssangglass
Copy link
Member Author

The last commit was on my company's virtual machine. Maybe it caused the security check to fail. In the evening I will submit from my own computer.

@spacewander spacewander merged commit 90109ca into apache:master Oct 17, 2020
@tzssangglass tzssangglass deleted the IssueNo1195 branch October 17, 2020 13:59
@moonming moonming added this to the 2.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: support multiple ports like stream listen in http and https listen port.
5 participants