Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin hot reload should work on node #2430

Merged
merged 6 commits into from
Nov 3, 2020
Merged

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Oct 15, 2020

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@spacewander spacewander changed the title WIP: fix: plugin hot reload should work on node fix: plugin hot reload should work on node Oct 18, 2020
@spacewander spacewander marked this pull request as ready for review October 18, 2020 11:55
@juzhiyuan juzhiyuan requested review from membphis and Miss-you and removed request for membphis October 26, 2020 08:44
@membphis
Copy link
Member

that is a big feature, I'll take a look at this PR when I time ^_^

many thx for your contribution @spacewander

apisix/core/set.lua Outdated Show resolved Hide resolved
apisix/plugins/prometheus.lua Show resolved Hide resolved
apisix/schema_def.lua Outdated Show resolved Hide resolved
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from codes style

@membphis membphis merged commit 432c954 into apache:master Nov 3, 2020
@membphis
Copy link
Member

membphis commented Nov 3, 2020

@spacewander many thx, merged already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants