Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add managed fields in json schema for resources, such as create_time and update_time #2444

Merged
merged 3 commits into from
Oct 17, 2020
Merged

feature: add managed fields in json schema for resources, such as create_time and update_time #2444

merged 3 commits into from
Oct 17, 2020

Conversation

nic-chen
Copy link
Member

@nic-chen nic-chen commented Oct 17, 2020 •
edited
Loading

What this PR does / why we need it:

add managed fields in json schema for resources, such as create_time and update_time

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

relate to #2433

@nic-chen nic-chen added this to the 2.0 milestone Oct 17, 2020
@nic-chen
Copy link
Member Author

add to milestone 2.0 because need these fields to work with new manager api #2444

juzhiyuan
juzhiyuan reviewed Oct 17, 2020
View reviewed changes
t/admin/consumers.t Show resolved Hide resolved
t/admin/routes.t Show resolved Hide resolved
membphis
membphis approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR ^_^

@membphis
Copy link
Member

@nic-chen I think you'd better add a link to the question in this PR. The community needs to know which issue is solved.

@nic-chen
Copy link
Member Author

@nic-chen I think you'd better add a link to the question in this PR. The community needs to know which issue is solved.

sure.I have modified the summary。

@nic-chen nic-chen merged commit a92331c into apache:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@moonming moonming Awaiting requested review from moonming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nic-chen @membphis @juzhiyuan @johzchen