change: make lrucache lock optional #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
force-pushed
the
refactor_lru
branch
from
8388350
to
c67b41c
Compare
spacewander
force-pushed
the
refactor_lru
branch
from
c67b41c
to
ac7690c
Compare
membphis
approved these changes
Nov 2, 2020
moonming
approved these changes
Nov 2, 2020
spacewander
commented
Nov 12, 2020
|
|
||
| if stale_obj and stale_obj.ver == version then | ||
| lru_global:set(key, stale_obj, PLUGIN_TTL) | ||
| return stale_obj |
There was a problem hiding this comment.
Here we need to return stale_obj.val instead. Otherwise, the returned value will be:
ver = xxx,
val = actual_cache_obj,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pre-submission checklist:
Close #2520