Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jwt-auth): support to use of the RS256 algorithm #2594

Merged
merged 10 commits into from
Nov 6, 2020
Merged

feat(jwt-auth): support to use of the RS256 algorithm #2594

merged 10 commits into from
Nov 6, 2020

Conversation

tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented Nov 1, 2020 •
edited by membphis
Loading

What this PR does / why we need it:

This is an example of #2523, not a real PR, just to show the use of the RS256 algorithm to run the jwt-auth plugin

fix #2523 and fix #2355

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@tzssangglass tzssangglass changed the title example of #2523 example: the use of the RS256 algorithm to run the jwt-auth plugin #2523 Nov 1, 2020
@juzhiyuan
Copy link
Member

then could we mark it as Draft?

@tzssangglass
Copy link
Member Author

then could we mark it as Draft?

ok

@tzssangglass
Copy link
Member Author

@membphis the example of #2523, pls take a look

@juzhiyuan juzhiyuan marked this pull request as draft November 2, 2020 01:31
@membphis membphis marked this pull request as ready for review November 2, 2020 13:17
@membphis membphis marked this pull request as draft November 2, 2020 13:19
@tzssangglass tzssangglass marked this pull request as ready for review November 3, 2020 23:58
@tzssangglass
Copy link
Member Author

ping @membphis

membphis
membphis reviewed Nov 5, 2020
View reviewed changes
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
@membphis membphis changed the title example: the use of the RS256 algorithm to run the jwt-auth plugin #2523 feat(jwt-auth): support to use of the RS256 algorithm Nov 5, 2020
@membphis membphis added the plugin label Nov 5, 2020
spacewander
spacewander reviewed Nov 5, 2020
View reviewed changes
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
doc/zh-cn/plugins/jwt-auth.md Show resolved Hide resolved
spacewander
spacewander reviewed Nov 5, 2020
View reviewed changes
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
apisix/plugins/jwt-auth.lua Outdated Show resolved Hide resolved
@tzssangglass
Copy link
Member Author

@spacewander thanks for the review.

@spacewander spacewander merged commit 27875e5 into apache:master Nov 6, 2020
@tzssangglass tzssangglass deleted the IssueNo2355 branch November 6, 2020 02:20
@spacewander spacewander mentioned this pull request Nov 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@membphis membphis Awaiting requested review from membphis

Assignees
No one assigned
Labels
plugin
Projects
None yet
Milestone
No milestone
4 participants
@tzssangglass @juzhiyuan @spacewander @membphis