Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate create/update_time automatically #2740

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Conversation

spacewander
Copy link
Member

Close #2654.

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

else
utils.inject_timestamp(conf, res.body)
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could put them in a function too,what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nic-chen
Changed.

@spacewander spacewander added this to the 2.1 milestone Nov 14, 2020
@moonming moonming merged commit da4e12e into apache:master Nov 15, 2020
@moonming moonming mentioned this pull request Nov 29, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants