Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: share etcd client #2932

Merged
merged 2 commits into from
Dec 15, 2020
Merged

feat: share etcd client #2932

merged 2 commits into from
Dec 15, 2020

Conversation

spacewander
Copy link
Member

Need to change lua-resty-etcd for this feature
For #2899

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
Copy link
Member Author

Required: api7/lua-resty-etcd#100

@spacewander spacewander mentioned this pull request Dec 2, 2020
Closed
@spacewander spacewander changed the title WIP:feat: share etcd client feat: share etcd client Dec 9, 2020
@spacewander spacewander force-pushed the share_cli branch 3 times, most recently from 1f3e4ae to 3db9912 Compare December 9, 2020 04:20
@spacewander
feat: share etcd client
fb66f19 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review December 9, 2020 08:04
membphis
membphis reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this PR after release version 2.2.

Because we updated the way to connect to etcd, it takes more time to confirm if it works

t/node/healthcheck-passive.t Show resolved Hide resolved
apisix/core/config_etcd.lua Outdated Show resolved Hide resolved
@spacewander
style
136bfa4 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
membphis
membphis approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spacewander spacewander merged commit d16ac7a into apache:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@membphis membphis membphis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacewander @membphis @tokers