feat: add control API #3048
Merged
feat: add control API #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
jbampton
reviewed
Dec 15, 2020
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
jbampton
reviewed
Dec 15, 2020
doc/control-api.md
Outdated
| port: 9090 | ||
| ``` | ||
|
|
||
| Note that the control API server should not be configured to listen the public traffic! |
There was a problem hiding this comment.
Suggested change
| Note that the control API server should not be configured to listen the public traffic! | |
| Note that the control API server should not be configured to listen to public traffic! |
doc/control-api.md
Outdated
| ## Control API Added via plugin | ||
|
|
||
| Plugin can add its control API when it is enabled. | ||
| If a plugin adds such control API, please refer to each plugin's documentation for those APIs. |
There was a problem hiding this comment.
Suggested change
| If a plugin adds such control API, please refer to each plugin's documentation for those APIs. | |
| If a plugin adds such a control API, please refer to each plugin's documentation for those APIs. |
membphis
requested changes
Dec 15, 2020
apisix/control/v1.lua
Outdated
| -- /v1/schema | ||
| { | ||
| methods = {"GET"}, | ||
| uri = "/schema", |
There was a problem hiding this comment.
use uris is better, we'll remove uri later
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tokers
reviewed
Dec 18, 2020
|
|
||
| ## Control API Added via plugin | ||
|
|
||
| Plugin can add its control API when it is enabled. |
There was a problem hiding this comment.
Shall we add the control API example in plugin-develop.md?
There was a problem hiding this comment.
Yes, but we can do it later. It seems the plugin-develop.md is outdated and need to be rewritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: