feat: support dubbo #3224
feat: support dubbo #3224
Conversation
spacewander
force-pushed
the
dubbo
branch
10 times, most recently
from
1d991cb
to
95b84d6
Compare
spacewander
force-pushed
the
dubbo
branch
19 times, most recently
from
19b6262
to
79596f6
Compare
spacewander
force-pushed
the
dubbo
branch
4 times, most recently
from
bd1223e
to
fc4dfc3
Compare
Fix apache#89 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
| <dubbo:application name="demo-provider"/> | ||
|
|
||
| <!-- use multicast registry center to export service --> | ||
| <dubbo:registry address="multicast://224.5.6.7:1234"/> |
There was a problem hiding this comment.
Multicast is for test and develop environment, not for the production.
There was a problem hiding this comment.
This part of code is just provided a test backend, it is not used for prod.
doc/plugins/dubbo-proxy.md
Outdated
|
|
||
| curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' | ||
| { | ||
| "methods": ["GET"], |
There was a problem hiding this comment.
user example, less is better. so we can remove this line
|
We need a way to avoid recompiling openresty every time in ci. We can implement this in a new PR. Now it takes 20 minutes, which is a bit long.
|
| cd t/lib/dubbo-backend | ||
| mvn package | ||
| cd dubbo-backend-provider/target | ||
| java -Djava.net.preferIPv4Stack=true -jar dubbo-demo-provider.one-jar.jar > /tmp/java.log & |
There was a problem hiding this comment.
LGTM
It is better to move t/lib/dubbo-backend to a separate repo, and only need to download the compiled jar when running CI.
There was a problem hiding this comment.
As the content of Java code is depended on what you want to test, it is inconvenient to move it to a separate repo.
There was a problem hiding this comment.
mvn package + java -Djava.net.preferIPv4Stack=true
How long does it usually take?
There was a problem hiding this comment.
@membphis
32 seconds
README.md
Outdated
| @@ -79,6 +79,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against | |||
| - **Multi protocols** | |||
|
|
|||
| - [TCP/UDP Proxy](doc/stream-proxy.md): Dynamic TCP/UDP proxy. | |||
| - [dubbo Proxy](doc/plugins/dubbo-proxy.md): Dynamic HTTP to dubbo proxy. | |||
t/plugin/dubbo-proxy/route.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 5: work with comsumer |
|
@spacewander Hi, can you please reply, will the dubbo backend service start automatically when running the test? I opened a PR #9660 that supports the dubbo protocol, and want to reuse the dubbo backend service, but by default, connection refused is returned. |
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: