Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix spelling #3253

Merged
merged 1 commit into from
Mar 14, 2021
Merged

chore: fix spelling #3253

merged 1 commit into from
Mar 14, 2021

Conversation

jbampton
Copy link
Member

What this PR does / why we need it:

Need to have correct spelling.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@membphis
Copy link
Member

I rerun the CI

@jbampton jbampton force-pushed the fix-spelling branch 2 times, most recently from 1545d11 to e8bccb0 Compare February 10, 2021 21:45
@jbampton jbampton requested a review from membphis February 10, 2021 22:15
@jbampton jbampton force-pushed the fix-spelling branch 2 times, most recently from f6f2902 to 8c1777f Compare February 21, 2021 13:34
@jbampton
Copy link
Member Author

Pinging @spacewander and @juzhiyuan I found another bunch of spelling mistakes today to make it 44 lines changed.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbampton jbampton force-pushed the fix-spelling branch 2 times, most recently from 9fb4fc4 to 331c476 Compare March 5, 2021 08:23
@membphis
Copy link
Member

membphis commented Mar 9, 2021

@Firstsawyou

Do you have time to find out why the test case failed? You can submit a patch for @jbampton

help him to finish this PR, many thx

@Firstsawyou
Copy link
Contributor

@Firstsawyou

Do you have time to find out why the test case failed? You can submit a patch for @jbampton

help him to finish this PR, many thx

The test case failure is caused by the following two reasons:

  1. In the test file of t/plugin/echo.t, userpasswrd should be userpassword.
diff --git a/t/plugin/echo.t b/t/plugin/echo.t
index e45fa89..97103a4 100644
--- a/t/plugin/echo.t
+++ b/t/plugin/echo.t
@@ -269,7 +269,7 @@ Location: https://www.iresty.com
                             "plugins": {
                                "echo": {
                                 "before_body": "before the body modification ",
-                                 "auth_value" : "userpasswrd",
+                                 "auth_value" : "userpassword",
                                 "headers": {
                                     "Location":"https://www.iresty.com"
                                 }

2、api7/jsonschema has not released a new version after sctrictly is fixed (sctrictly -> strictly). We need to release a new version of api7/jsonschema to support strictly.

@membphis
Copy link
Member

2、api7/jsonschema has not released a new version after sctrictly is fixed (sctrictly -> strictly). We need to release a new version of api7/jsonschema to support strictly.

welcome to submit a pr, then I can release a new version

@Firstsawyou
Copy link
Contributor

2、api7/jsonschema has not released a new version after sctrictly is fixed (sctrictly -> strictly). We need to release a new version of api7/jsonschema to support strictly.

welcome to submit a pr, then I can release a new version

The PR has been submitted:api7/jsonschema#57

@membphis
Copy link
Member

The PR has been submitted:api7/jsonschema#57

merged and released new version, please take a look:

image

@Firstsawyou
Copy link
Contributor

Hi, @jbampton
A new version of api7/jsonschema has been released, you can now try to update the following two parts of the code:

diff --git a/rockspec/apisix-master-0.rockspec b/rockspec/apisix-master-0.rockspec
index 1806b7c..37f911f 100644
--- a/rockspec/apisix-master-0.rockspec
+++ b/rockspec/apisix-master-0.rockspec
@@ -50,7 +50,7 @@ dependencies = {
     "luafilesystem = 1.7.0-2",
     "lua-tinyyaml = 1.0",
     "nginx-lua-prometheus = 0.20201218",
-    "jsonschema = 0.9.3",
+    "jsonschema = 0.9.4",
     "lua-resty-ipmatcher = 0.6",
     "lua-resty-kafka = 0.07",
     "lua-resty-logger-socket = 2.0-0",
diff --git a/t/plugin/echo.t b/t/plugin/echo.t
index e45fa89..97103a4 100644
--- a/t/plugin/echo.t
+++ b/t/plugin/echo.t
@@ -269,7 +269,7 @@ Location: https://www.iresty.com
                             "plugins": {
                                "echo": {
                                 "before_body": "before the body modification ",
-                                 "auth_value" : "userpasswrd",
+                                 "auth_value" : "userpassword",
                                 "headers": {
                                     "Location":"https://www.iresty.com"
                                 }

@membphis membphis merged commit 4ebccaf into apache:master Mar 14, 2021
@membphis
Copy link
Member

@jbampton many thx

@jbampton
Copy link
Member Author

Thank you @membphis 👍

@jbampton jbampton deleted the fix-spelling branch March 14, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants