-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix spelling #3253
chore: fix spelling #3253
Conversation
I rerun the CI |
0b09d37
to
4158fed
Compare
1545d11
to
e8bccb0
Compare
f6f2902
to
8c1777f
Compare
Pinging @spacewander and @juzhiyuan I found another bunch of spelling mistakes today to make it 44 lines changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9fb4fc4
to
331c476
Compare
Do you have time to find out why the test case failed? You can submit a patch for @jbampton help him to finish this PR, many thx |
The test case failure is caused by the following two reasons:
2、api7/jsonschema has not released a new version after |
welcome to submit a pr, then I can release a new version |
The PR has been submitted:api7/jsonschema#57 |
merged and released new version, please take a look: |
Hi, @jbampton diff --git a/rockspec/apisix-master-0.rockspec b/rockspec/apisix-master-0.rockspec
index 1806b7c..37f911f 100644
--- a/rockspec/apisix-master-0.rockspec
+++ b/rockspec/apisix-master-0.rockspec
@@ -50,7 +50,7 @@ dependencies = {
"luafilesystem = 1.7.0-2",
"lua-tinyyaml = 1.0",
"nginx-lua-prometheus = 0.20201218",
- "jsonschema = 0.9.3",
+ "jsonschema = 0.9.4",
"lua-resty-ipmatcher = 0.6",
"lua-resty-kafka = 0.07",
"lua-resty-logger-socket = 2.0-0",
diff --git a/t/plugin/echo.t b/t/plugin/echo.t
index e45fa89..97103a4 100644
--- a/t/plugin/echo.t
+++ b/t/plugin/echo.t
@@ -269,7 +269,7 @@ Location: https://www.iresty.com
"plugins": {
"echo": {
"before_body": "before the body modification ",
- "auth_value" : "userpasswrd",
+ "auth_value" : "userpassword",
"headers": {
"Location":"https://www.iresty.com"
} |
@jbampton many thx |
Thank you @membphis 👍 |
What this PR does / why we need it:
Need to have correct spelling.
Pre-submission checklist: