feat: support gRPCS #3411
Merged
feat: support gRPCS #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
force-pushed
the
grpcs
branch
3 times, most recently
from
78fbb38
to
05c238c
Compare
Fix apache#3344. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tokers
approved these changes
Jan 25, 2021
membphis
reviewed
Jan 25, 2021
| @@ -554,6 +554,52 @@ http { | |||
| } | |||
| } | |||
|
|
|||
| {% if use_or_1_15 then %} | |||
There was a problem hiding this comment.
do we have to support openresty 1.15?
I think we can only support 1.19 and 1.17. we can update cli.
There was a problem hiding this comment.
what do you think? @spacewander
There was a problem hiding this comment.
IMHO, 1.15 is released in 2019, and Kong still supports it. Maybe we can give it one more chance.
moonming
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3344.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: