-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refine example grafana dashboard #3457
Conversation
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
doc/plugins/prometheus.md
Outdated
@@ -120,6 +120,10 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719) | |||
|
|||
![](../../doc/images/plugin/grafana_3.png) | |||
|
|||
![](../../doc/images/plugin/grafana_4.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are currently two problems for histogram:
- The legends have leading for trailing zeros (reason) so it looks messy
- There are two many buckets out there. We don't need buckets like "30,40,50,60,70,80,90,100,200,300,400,500". After reduce buckets, it somewhat looks better
Or we could use 95-percentile as @tokers said. I'm not so familiar with monitor APISIX, so what do you think about that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For etcd-reachable
and nginx metric errors
, the comments of what these two metrics do are explained on the metrics page alongside with the data. And for how I implement it
etcd-reachable
: when etcd is reachable, the metric would be 1 and the graph would be green. While it is disconnected, the metric turns to 0 and the panel would be red.nginx metric errors
: it measures how many errors of nginx-lua-prometheus. I also leave it to only show the current error number, since if it is larger than 0, it should be taken care of. And also if it is larger than 0, it would turn red.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would fix leading for trailing zeros in knyar/nginx-lua-prometheus#119
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the HTTP requests latency can be updated to only show the 95th percentile (or 90th?), it's not easy to understand now. |
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
waiting for knyar/nginx-lua-prometheus#119 got merged PR got merged, waiting for new release Applied the new release |
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
agree +1 |
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this PR does / why we need it:
Ref #3402
Pre-submission checklist: