-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: the traffic-split plugin supports upstream_id #3512
feat: the traffic-split plugin supports upstream_id #3512
Conversation
What is the relationship between this pr and #3094? I didn't see it |
I still don't know why health check and retry mechanism are depends on upstream id? |
Use the upstream_id method in the plugin to refer to the upstream that has been defined, so that we can reuse the health checks and retries that upstream already has, instead of repeatedly implementing them in the plugin. |
These should be explained in detail as much as possible in the issue and PR |
d1112f4
to
fd3f4c7
Compare
What this PR does / why we need it:
close #3094
How to implement the health check and retry mechanism:
Use the upstream_id method in the plugin to refer to the defined upstream so that we can reuse the health detection and retry mechanism that the upstream already has.
Reasons for the init.lua file to adjust the execution order of plugins:
Since the upstream_id in the init.lua file is processed before the plugin is executed, it will cause the upstream_id setting in the traffic-split plugin to take effect. Therefore, this
PR
adjusts the logic code executed by the plug-in in the init.lua file before the processing ofupstream_id
.Pre-submission checklist: