feat(zipkin): support b3 req header #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix apache#1125 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tokers
approved these changes
Feb 7, 2021
membphis
reviewed
Feb 20, 2021
apisix/plugins/zipkin.lua
Outdated
| err, trace_id, request_span_id, sampled, parent_span_id = parse_b3(b3) | ||
|
|
||
| if err then | ||
| core.log.warn("invalid b3 header: ", b3, ", ignored: ", err) |
There was a problem hiding this comment.
@membphis
Raise error in a request may be considered a bug of APISIX (as it will provide 500 and backtrack).
Maybe we can return 400 to reject it?
There was a problem hiding this comment.
I think 400 is better, since an invalid header is always caused by client.
There was a problem hiding this comment.
I think
400is better, since an invalid header is always caused by client.
agree this too.
Raise error in a request may be considered a bug of APISIX (as it will provide 500 and backtrack).
I means core.log.error(****) ^_^
membphis
approved these changes
Feb 20, 2021
|
@Yiyiyimu Chaos Test failed, do you have time to look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1125
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: