fix: should assign value to api_ctx.global_rules before running global rules

[nic-chen]

What this PR does / why we need it:

this bug introduced by #3396.

should assign value to api_ctx.global_rules before running global rules, otherwise if a plugin exits in the access phase, global rules will not be able to run in the subsequent phases.

Pre-submission checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases?
• Have you modified the corresponding document?
• Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

[moonming]

Is this a bug? Which PR introduced it?

[spacewander]

Do it in run_global_rules?
Need to update the api_router.lua too

[nic-chen]

@spacewander
Thanks for reviewing.
I still have some doubts. The original code also assign value to api_ctx.global_rules after run_plugin, but it does not cause a bug like this. .

[nic-chen]

@spacewander
Thanks for reviewing.
I still have some doubts. The original code also assign value to api_ctx.global_rules after run_plugin, but it does not cause a bug like this. .

I re-checked the original code, it filtered plugins of global rule and assigned them to api_ctx.plugins, that is why..

[nic-chen]

Is this a bug? Which PR introduced it?

yes, it's a bug. it's introduced by #3396

[nic-chen]

@membphis @tokers @moonming please have a look when you have time, thanks.

[tokers]

@nic-chen Could you tell me where we use api_ctx.global_rules? I saw the assignment but not found the usage.

[nic-chen]

@nic-chen Could you tell me where we use api_ctx.global_rules? I saw the assignment but not found the usage.

use in:
https://github.com/apache/apisix/blob/master/apisix/init.lua#L481

and define in:
https://github.com/apache/apisix/blob/master/apisix/plugin.lua#L685-L714

you could also have a look at the prev PR #3396 for more detail.

[nic-chen]

yes, it's a bug. it's introduced by #3396

Actually #3396 is not the real cause of the bug, but it exposes the bug

[tokers]

@nic-chen Could you tell me where we use api_ctx.global_rules? I saw the assignment but not found the usage.

use in:
https://github.com/apache/apisix/blob/master/apisix/init.lua#L481

and define in:
https://github.com/apache/apisix/blob/master/apisix/plugin.lua#L685-L714

you could also have a look at the prev PR #3396 for more detail.

Got it.

[membphis]

better style, we can fix it in a new PR

function _M.run_global_rules(api_ctx, global_rules, phase_name)
    if not global_rules or not global_rules.values
       and #global_rules.values == 0 then
        return
    end

    -- your code
end

[nic-chen]

better style, we can fix it in a new PR

function _M.run_global_rules(api_ctx, global_rules, phase_name)
    if not global_rules or not global_rules.values
       and #global_rules.values == 0 then
        return
    end

    -- your code
end

OK