Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add consul kv discovery module #3615

Merged
merged 11 commits into from
Feb 23, 2021
Merged

Conversation

yongboy
Copy link
Contributor

@yongboy yongboy commented Feb 20, 2021

What this PR does / why we need it:

As I mentioned previously in the mail-list, my team submit the consul_kv discovery module now.

More introductions here:
https://github.com/yongboy/apisix/blob/consul_kv/doc/discovery/consul_kv.md

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tokers
Copy link
Contributor

tokers commented Feb 20, 2021

@yongboy The linters failed, you may try to run make lint on your side and fix all lint errors.

apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
doc/discovery/consul_kv.md Outdated Show resolved Hide resolved
doc/discovery/consul_kv.md Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
doc/discovery.md Outdated Show resolved Hide resolved
doc/discovery/consul_kv.md Outdated Show resolved Hide resolved
doc/discovery/consul_kv.md Outdated Show resolved Hide resolved
doc/discovery/consul_kv.md Outdated Show resolved Hide resolved
doc/discovery/consul_kv.md Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
apisix/discovery/consul_kv.lua Outdated Show resolved Hide resolved
@spacewander spacewander merged commit 8b7d937 into apache:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants