Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: script does not work when the route is bound to a service. #3678

Merged
merged 4 commits into from
Feb 26, 2021
Merged

fix: script does not work when the route is bound to a service. #3678

merged 4 commits into from
Feb 26, 2021

Conversation

tzssangglass
Copy link
Member

What this PR does / why we need it:

fix: #3663

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tzssangglass tzssangglass changed the title bugfix: fix script does not work when route binding service bugfix: fix script does not work when route binding service. Feb 25, 2021
@tzssangglass tzssangglass changed the title bugfix: fix script does not work when route binding service. bugfix: fix script does not work when the route is bound to a service. Feb 25, 2021
@tzssangglass
Copy link
Member Author

@spacewander @membphis CI is ok, but I don't koow why PR title is solecistic

@Firstsawyou
Copy link
Contributor

Your PR title needs to look like this: fix: script does not work when the route is bound to a service

@spacewander spacewander changed the title bugfix: fix script does not work when the route is bound to a service. fix: script does not work when the route is bound to a service. Feb 26, 2021
tokers
tokers reviewed Feb 26, 2021
View reviewed changes
t/admin/script.t Outdated Show resolved Hide resolved
spacewander
spacewander reviewed Feb 26, 2021
View reviewed changes
t/admin/script.t Outdated Show resolved Hide resolved
@membphis membphis merged commit a6fbcce into apache:master Feb 26, 2021
@tzssangglass tzssangglass deleted the IssueNo3663 branch February 26, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers left review comments

@membphis membphis membphis approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: script does not work
5 participants
@tzssangglass @Firstsawyou @spacewander @membphis @tokers