feat: support SRV record #3686
Merged
feat: support SRV record #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tokers
reviewed
Feb 27, 2021
| log.info("dns resolve SRV ", answer.target, ", result: ", | ||
| json.delay_encode(resolved)) | ||
|
|
||
| local weight = answer.weight |
There was a problem hiding this comment.
I think the explantation to treat zero weight record to 1 https://github.com/apache/apisix/blob/3af2175629f727d0374b7f77dbdc3a510cf44d81/docs/en/latest/dns.md#srv-record, can also add here.
There was a problem hiding this comment.
apisix/core/dns/client.lua
Outdated
|
|
||
| -- find the least common multiple of the counts | ||
| local lcm = answer_to_count[answers[1]] | ||
| for i = 1, #answers do |
membphis
approved these changes
Feb 27, 2021
membphis
requested changes
Feb 27, 2021
docs/en/latest/dns.md
Outdated
| { | ||
| "id": 1, | ||
| "type": "roundrobin", | ||
| "nodes": { |
There was a problem hiding this comment.
should use [ here, it an array object here.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
membphis
approved these changes
Feb 27, 2021
tokers
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: